up to python 3.10 #269
Closed
up to python 3.10 #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +92,7 @@ def expr(val, nesting_depth=20): | |||
|
|
|||
| if isinstance(val, RqlQuery): | |||
| return val | |||
| elif isinstance(val, collections.Callable): | |||
| elif isinstance(val, collections.abc.Callable): | |||
There was a problem hiding this comment.
change also needed for collections.Mapping
gabor-boros
reviewed
May 11, 2022
| @@ -202,7 +202,7 @@ def connect(self, timeout): | |||
| self._streamreader, self._streamwriter = yield from asyncio.open_connection( | |||
| self._parent.host, | |||
| self._parent.port, | |||
| loop=self._io_loop, | |||
| #loop=self._io_loop, droped at py3.10 | |||
There was a problem hiding this comment.
This makes the driver backward incompatible with older python versions.
There was a problem hiding this comment.
It does? How so? The parameter was optional and otherwise it uses the active loop.
|
Going to close, because, first, this only drops one of the loop parameters (there are a couple more that need to be dropped) and second, the change to And PR #296 removes all the loop params that need it. Also, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use with python 3.10 some little changes are necesary.
Callable uses collections.abc
Drop loop arg